refactor(wallet): Remove usage of blockdata:: from bitcoin paths#1490
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jun 28, 2024
Merged
refactor(wallet): Remove usage of blockdata:: from bitcoin paths#1490notmandatory merged 1 commit intobitcoindevkit:masterfrom
blockdata:: from bitcoin paths#1490notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
tcharding
changed the title
blockdata:: from bitcoin paths
tcharding
force-pushed
the
06-26-import-paths
branch
from
2d0f829 to
66b29f4
Compare
notmandatory
approved these changes
Jun 27, 2024
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK 66b29f4
Thanks for the heads up and fix!
tcharding
force-pushed
the
06-26-import-paths
branch
from
66b29f4 to
851663a
Compare
Contributor
Author
|
No sweat, force push is rebase only. |
In `rust-bitcoin` the `blockdata` module is a code organisation thing, it should never have been public. One day those guys would like to remove it, so as not to be a PITA for `bdk` when they do lets remove all usage of `blockdata::` now. Internal change only, no externally visible changes.
tcharding
force-pushed
the
06-26-import-paths
branch
from
851663a to
cf7aca8
Compare
Contributor
Author
|
... and fix formatting |
notmandatory
changed the title
blockdata:: from bitcoin pathsblockdata:: from bitcoin paths.
notmandatory
changed the title
blockdata:: from bitcoin paths.blockdata:: from bitcoin paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
rust-bitcointheblockdatamodule is a code organisation thing, it should never have been public. One day those guys would like to remove it, so as not to be a PITA forbdkwhen they do lets remove all usage ofblockdata::now.Changelog notice
Internal change only, no externally visible changes.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing