refactor(wallet)!: Simplify public_descriptor(), remove redundant function

[gnapoli23]

Fixes #1501

Description

Simplifies public_descriptor function by using get_descriptor and removes get_descriptor_for_keychain.

Notes to the reviewers

Tested with cargo test --all-features.

Changelog notice

• Simplifies public_descriptor function and removes get_descriptor_for_keychain

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[notmandatory]

Looks good, one suggestion for the docs.

[notmandatory]

One final thing, you need to setup a github signing key and squash and sign your commit.
see: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

[gnapoli23]

One final thing, you need to setup a github signing key and squash and sign your commit. see: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

Sure, I thought I signed it with my yubikey but I just pushed it without signing. Going to fix in a brief.

[gnapoli23]

Done. @notmandatory

[notmandatory]

I just realized you also should update the commit message to conform to https://www.conventionalcommits.org/en/v1.0.0/.

We don't usually put github issue numbers in commit messages, so something like this:

refactor(wallet)!: remove redundant Wallet::get_descriptor_for_keychain()

Simplify Wallet::public_descriptor() and update Wallet internals to use public_descriptor() instead of get_descriptor_for_keychain().

[gnapoli23]

@notmandatory Updated following your suggestions, please let me know if something else needs to be fixed. Thanks.

[storopoli]

The commit message is still too wide, 50 chars for title and 72 for body:

Suggestion:

refactor(wallet)!: remove redundant get_descriptor_for_keychain

Simplify Wallet::public_descriptor() and update Wallet internals to use
public_descriptor() instead of get_descriptor_for_keychain().

[gnapoli23]

Ok, please check now. @notmandatory @storopoli

[notmandatory]

ACK e7ec5a8

Thanks for getting this one wrapped up.

[storopoli]

ACK e7ec5a8

[gnapoli23]

Thanks to both of you @notmandatory @storopoli . Can it be merged now?