Skip to content

feat(chain): export type alias for FutureResult#1556

Closed
rustaceanrob wants to merge 1 commit intobitcoindevkit:masterfrom
rustaceanrob:alias-08-13
Closed

feat(chain): export type alias for FutureResult#1556
rustaceanrob wants to merge 1 commit intobitcoindevkit:masterfrom
rustaceanrob:alias-08-13

Conversation

@rustaceanrob
Copy link
Copy Markdown
Contributor

Description

Similar to BoxedFuture it may be helpful for users to use this alias when implementing PersistAsyncWith

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8ee6c02

@evanlinjin
Copy link
Copy Markdown
Member

ConceptACK.

However, given that #1547 will go into beta (based on my understanding), it might be better to base this on that! I'm wondering the same thing for #1552

@rustaceanrob
Copy link
Copy Markdown
Contributor Author

Rebased, although I did not review the recent PRs so I am not sure if this is still helpful.

@evanlinjin
Copy link
Copy Markdown
Member

I'm thinking now, that the better approach would be to depend on futures-core = { version = "0.3" }.

@rustaceanrob
Copy link
Copy Markdown
Contributor Author

futures_core contains a FutureResult type. Closing this

@rustaceanrob rustaceanrob deleted the alias-08-13 branch September 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants