Skip to content

ci: automated update to rustc 1.80.1#1570

Closed
github-actions[bot] wants to merge 1 commit intomasterfrom
create-pull-request/update-rust-version
Closed

ci: automated update to rustc 1.80.1#1570
github-actions[bot] wants to merge 1 commit intomasterfrom
create-pull-request/update-rust-version

Conversation

@github-actions
Copy link
Copy Markdown

Automated update to Github CI workflow cont_integration.yml by create-pull-request GitHub action

@notmandatory
Copy link
Copy Markdown
Member

for some reason the actions aren't running 🤔

@oleonardolima
Copy link
Copy Markdown
Collaborator

for some reason the actions aren't running 🤔

https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-inputs 😞

Note: If you want pull requests created by this action to trigger an on: push or on: pull_request workflow then you cannot use the default GITHUB_TOKEN. See the documentation here for workarounds.

@storopoli
Copy link
Copy Markdown

Yeah that's why rust-bitcoin uses a token from apoelstra in their cron CI job to update stable rust version.

      - name: Create Pull Request
        if: env.changes_made == 'true'
        uses: peter-evans/create-pull-request@v6
        with:
          token: ${{ secrets.APOELSTRA_CREATE_PR_TOKEN }}
          author: Update Stable Rustc Bot <bot@example.com>
          committer: Update Stable Rustc Bot <bot@example.com>
          title: Automated weekly update to rustc stable (to ${{ env.stable_version }})
          body: |
           Automated update to Github CI workflow `semver-checks.yml` by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action
          commit-message: Automated update to Github CI to rustc stable-${{ env.stable_version }}
          branch: create-pull-request/weekly-stable-update

@notmandatory
Copy link
Copy Markdown
Member

Attempted actions permission fix here: #1580

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b3f0541

DONT MERGE. I'm just checking to see if this is approved it is merge-able.

@notmandatory
Copy link
Copy Markdown
Member

Oh drat, the commits also need to be signed. I'll see if I can fix it in #1580.

@create-pr-actions create-pr-actions Bot force-pushed the create-pull-request/update-rust-version branch from b3f0541 to bb02ed6 Compare August 30, 2024 15:37
@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Aug 30, 2024

Looks like it leaves the original PR open (and force pushed new commit) when I re-ran the workflow with my changes from #1580. At least now the workflow ran and commit is verified signed.

Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bb02ed6 Still confused why it needs to run ci twice though.

@notmandatory
Copy link
Copy Markdown
Member

I'm closing this PR and deleting the branch so we can let cron run it on the 15th and generate a PR without me triggering it.

@notmandatory notmandatory deleted the create-pull-request/update-rust-version branch August 30, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants