Skip to content

docs: update CONTRIBUTING.md#1584

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:doc/contributing
Sep 5, 2024
Merged

docs: update CONTRIBUTING.md#1584
notmandatory merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:doc/contributing

Conversation

@ValuedMammal
Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal commented Aug 30, 2024

Update CONTRIBUTING.md

  • Made small corrections and added some things that were missing. If there's something else you think should be included let me know.

closes #1394

Changelog notice

Checklists

All Submissions:

@notmandatory notmandatory added the documentation Improvements or additions to documentation label Aug 30, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Aug 30, 2024
notmandatory
notmandatory approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6b881f8

@LagginTimes
Copy link
Copy Markdown
Contributor

LagginTimes commented Sep 1, 2024

ACK 6b881f8

storopoli
storopoli approved these changes Sep 1, 2024
View reviewed changes
Copy link
Copy Markdown

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6b881f8

oleonardolima
oleonardolima approved these changes Sep 1, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6b881f8

@notmandatory notmandatory merged commit 257c5f7 into bitcoindevkit:master Sep 5, 2024
@ValuedMammal ValuedMammal deleted the doc/contributing branch September 5, 2024 20:04
This was referenced Sep 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

@oleonardolima oleonardolima oleonardolima approved these changes

+1 more reviewer

@storopoli storopoli storopoli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ValuedMammal ValuedMammal

Labels

documentation Improvements or additions to documentation

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-beta

Development

Successfully merging this pull request may close these issues.

Have more code conventions and guidelines

5 participants

@ValuedMammal @LagginTimes @notmandatory @oleonardolima @storopoli