Skip to content

doc(wallet): Add docs to explain the lookahead#1596

Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:doc/miscellaneous
Sep 16, 2024
Merged

doc(wallet): Add docs to explain the lookahead#1596
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
ValuedMammal:doc/miscellaneous

Conversation

@ValuedMammal
Copy link
Copy Markdown
Collaborator

Adds clarifying language to CreateParams and LoadParams regarding the lookahead parameter. Commit 028f687 also includes some minor documentation fixes.

If anyone is aware of any more documentation flaws that need attention I'm happy to add them here.

cc bitcoindevkit/bdk_wallet#83

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal ValuedMammal self-assigned this Sep 9, 2024
@ValuedMammal ValuedMammal added this to the 1.0.0-beta milestone Sep 9, 2024
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 028f687

Comment thread crates/wallet/src/wallet/params.rs
Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 028f687

@LagginTimes
Copy link
Copy Markdown
Contributor

ACK 028f687

@ValuedMammal ValuedMammal merged commit 2cf46a2 into bitcoindevkit:master Sep 16, 2024
@ValuedMammal ValuedMammal deleted the doc/miscellaneous branch September 16, 2024 16:26
@ValuedMammal ValuedMammal mentioned this pull request Oct 2, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants