feat(rpc): introduce FilterIter#1614
Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom Jan 27, 2025
Merged
Conversation
Member
|
This is what we've all been waiting for. |
ValuedMammal
commented
Sep 17, 2024
f001fd4 to
aa8c49e
Compare
Collaborator
|
ConceptACK. Don't have time for a full review now. @evanlinjin? |
Collaborator
Author
|
Thanks for the review @oleonardolima |
7d34480 to
f74580c
Compare
Collaborator
Author
|
Rebased and addressed comments from @oleonardolima |
455c16c to
1074412
Compare
1074412 to
c0f16e0
Compare
nymius
reviewed
Jan 9, 2025
c0f16e0 to
db65d96
Compare
Collaborator
Author
|
In the last push
CI failure seems unrelated |
19a5926 to
7ad95d3
Compare
Collaborator
Author
|
Rebased |
nymius
reviewed
Jan 20, 2025
nymius
approved these changes
Jan 21, 2025
7ad95d3 to
8fc03ee
Compare
Collaborator
Author
|
Rebased |
a36a5a8 to
f34cc9b
Compare
notmandatory
approved these changes
Jan 25, 2025
Member
There was a problem hiding this comment.
tACK a6364e2
This is cool stuff, I added some docs to make it easier for others to run.
f34cc9b to
a6364e2
Compare
Collaborator
Author
|
Thanks @notmandatory |
Member
|
We need to test this against reorgs. It seems like the architecture of this may result in inconsistent state of checkpoints during reorgs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds a
bip158module to thebdk_bitcoind_rpccrate along with a new typeFilterIterthat can be used for retrieving blocks from a full node which contain transactions relevant to a list of script pubkeys.Notes to the reviewers
Changelog notice
bdk_bitcoind_rpc: Addedbip158module as a means of updatingbdk_chainstructuresChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: