Skip to content

fix!(wallet): ChangeSet should not be non-exhaustive#1623

Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
evanlinjin:fix/1591-wallet-changeset-should-not-be-non-exhaustive
Sep 28, 2024
Merged

fix!(wallet): ChangeSet should not be non-exhaustive#1623
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
evanlinjin:fix/1591-wallet-changeset-should-not-be-non-exhaustive

Conversation

@evanlinjin
Copy link
Copy Markdown
Member

@evanlinjin evanlinjin commented Sep 26, 2024

Closes #1591

Description

As stated in #1591, it is handy to know when new values are added to ChangeSet.

Notes to the reviewers

~

Changelog notice

  • Remove #[non_exhaustive] attribute from wallet::ChangeSet.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

As stated in bitcoindevkit#1591, it is handy to know when new values are added to
`ChangeSet`.
@evanlinjin evanlinjin added this to the 1.0.0-beta milestone Sep 26, 2024
@evanlinjin evanlinjin self-assigned this Sep 26, 2024
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d7dfe38

Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d7dfe38

@ValuedMammal ValuedMammal merged commit 4942cc6 into bitcoindevkit:master Sep 28, 2024
@ValuedMammal ValuedMammal mentioned this pull request Oct 2, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Should bdk_wallet::ChangeSet really be non_exhaustive?

3 participants