fix(wallet): fix building change signers in load_with_params#1662
Merged
evanlinjin merged 2 commits intobitcoindevkit:masterfrom Oct 29, 2024
Merged
fix(wallet): fix building change signers in load_with_params#1662evanlinjin merged 2 commits intobitcoindevkit:masterfrom
load_with_params#1662evanlinjin merged 2 commits intobitcoindevkit:masterfrom
Conversation
This fixes an issue that prevented change signers from being built when using the `keymap` method on `LoadParams`. Now we always build a `SignersContainer` with the internal keymap whenever a change descriptor is loaded, although the signer may still be empty if neither `keymap` nor `extract_keys` is used.
evanlinjin
approved these changes
Oct 29, 2024
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
ACK b6b767f
This was my oversight. Thanks for fixing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue that prevented change signers from being built when using the
keymapmethod onLoadParams. Now we always build aSignersContainerwith the internal keymap whenever a change descriptor is loaded. Note, the signer may still be "empty" if neitherkeymaporextract_keysis used.Notes to the reviewers
Building a
SignersContainernow happens outside of the match statement inload_with_paramswhich simplifies the logic such that we can interpret this area of code as "initialize a value forchange_descriptorand optionally extend the internal keymap, returning aLoadMismatcherror if the changeset doesn't match the expected params."Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: