Skip to content

types: Make Utxo::Foreign::sequence not optional#1681

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
stevenroose:foreign-sequence-opt
Nov 21, 2024
Merged

types: Make Utxo::Foreign::sequence not optional#1681
notmandatory merged 1 commit intobitcoindevkit:masterfrom
stevenroose:foreign-sequence-opt

Conversation

@stevenroose
Copy link
Copy Markdown
Contributor

It's never kept internally as optional at this point.

@notmandatory notmandatory added module-wallet api A breaking API change labels Nov 15, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 15, 2024
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2a7ddfb

Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2a7ddfb

It's never kept internally as optional at this point.
@notmandatory
Copy link
Copy Markdown
Member

I signed the commit so this can be merged.

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReACK d96dac4

@notmandatory notmandatory merged commit e7e552c into bitcoindevkit:master Nov 21, 2024
@notmandatory notmandatory mentioned this pull request Dec 11, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A breaking API change module-wallet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants