test(electrum): test for checking that fee calculation is correct#1685
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Jan 21, 2025
Merged
Conversation
Contributor
|
Thank you for taking this on! It looks good to me so far. Edit: Also just a reminder to address the clippy warning. |
f3r10
force-pushed
the
test_electrum_fee_calculation
branch
from
5ed5266 to
99888fa
Compare
LagginTimes
reviewed
Dec 2, 2024
Contributor
LagginTimes
left a comment
LagginTimes
left a comment
There was a problem hiding this comment.
To ensure the CI tests pass, please rebase your PR and ensure the clippy warning has been fixed. Once that's done, everything should be good to go!
f3r10
force-pushed
the
test_electrum_fee_calculation
branch
2 times, most recently
from
6b67cab to
836b097
Compare
Contributor
|
ACK 836b097 |
LagginTimes
suggested changes
Dec 7, 2024
Contributor
LagginTimes
left a comment
LagginTimes
left a comment
There was a problem hiding this comment.
It looks like another rebase is needed to ensure everything is up to date. Thank you for your continued efforts!
f3r10
force-pushed
the
test_electrum_fee_calculation
branch
from
836b097 to
fb7ca7e
Compare
f3r10
force-pushed
the
test_electrum_fee_calculation
branch
2 times, most recently
from
e6aae33 to
ecd3c3a
Compare
Contributor
Author
Sorry @LagginTimes I did not sign the commit 😞 |
f3r10
force-pushed
the
test_electrum_fee_calculation
branch
from
ecd3c3a to
06e5248
Compare
Collaborator
|
@f3r10 Can you rebase to trigger a CI run? |
f3r10
force-pushed
the
test_electrum_fee_calculation
branch
from
06e5248 to
cd591f1
Compare
Collaborator
|
@f3r10 Can you sign commits also? |
f3r10
force-pushed
the
test_electrum_fee_calculation
branch
from
cd591f1 to
f429973
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a unit test for checking that the fee calculation of
bdk_electrumis correct.Notes to the reviewers
fixes: #1444
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing