Use bitcoin::constants::COINBASE_MATURITY#1727
Use bitcoin::constants::COINBASE_MATURITY#1727notmandatory merged 1 commit intobitcoindevkit:masterfrom
bitcoin::constants::COINBASE_MATURITY#1727Conversation
notmandatory
added
audit
|
|
||
| /// How many confirmations are needed f or a coinbase output to be spent. | ||
| pub const COINBASE_MATURITY: u32 = 100; | ||
|
|
There was a problem hiding this comment.
This was a public method and removing it breaks the public API.
Could you add pub use bitcoin::constants::COINBASE_MATURITY in the top of this file?
There was a problem hiding this comment.
I am unsure if stylistic or for another reason, but BDK does not export types via pub use anywhere else in the crate. What do you think @notmandatory @ValuedMammal
There was a problem hiding this comment.
Although it's a breaking change on the API, it's fixing the API and you can use it from rust-bitcoin (e.g. bdk_chain::bitcoin::constants::COINBASE_MATURITY), which is re-exported.
There was a problem hiding this comment.
I agree this is a breaking change, but it's OK to require downstream projects to switch to explicitly use bdk_chain::bitcoin::constants::COINBASE_MATURITY since we'll be rolling this out in the 1.0.0 major release.
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
After answering the comment above I noticed it, and I guess you'd need to update the commit message to fix(wallet, chain)!: ... instead.
rustaceanrob
force-pushed
the
maturity-11-16
branch
from
3869705 to
309a607
Compare
4 participants
Closes #1692
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: