Sqlite - allow persisting anchor without tx#1736
Merged
evanlinjin merged 4 commits intobitcoindevkit:masterfrom Nov 28, 2024
Merged
Sqlite - allow persisting anchor without tx#1736evanlinjin merged 4 commits intobitcoindevkit:masterfrom
evanlinjin merged 4 commits intobitcoindevkit:masterfrom
Conversation
Member
Author
|
@ValuedMammal feel free to take this one over. I'm assuming this will fix the problem, but needs tests. |
Member
|
Tests from #961 could be useful. |
notmandatory
added
module-database
audit
ValuedMammal
force-pushed
the
fix/sqlite-insert-anchor-before-tx
branch
from
0aa1f24 to
4a71cf4
Compare
Previously, we may error when we insert an anchor where the txid being anchored has no corresponding tx.
evanlinjin
force-pushed
the
fix/sqlite-insert-anchor-before-tx
branch
from
4a71cf4 to
18f5f3f
Compare
Member
Author
|
@ValuedMammal I forced pushed to rebase on master. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, we may error when we insert an anchor where the txid being anchored has no corresponding tx.
closes #1712
replaces #961
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: