deps(esplora): bump esplora-client to 0.11.0#1746
Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom Dec 6, 2024
Merged
deps(esplora): bump esplora-client to 0.11.0#1746notmandatory merged 2 commits intobitcoindevkit:masterfrom
esplora-client to 0.11.0#1746notmandatory merged 2 commits intobitcoindevkit:masterfrom
Conversation
Collaborator
Author
|
❓ I think this Lines 29 to 31 in f6c1c61 |
165e503 to
90fd1a2
Compare
Member
You're right, |
notmandatory
approved these changes
Dec 4, 2024
Member
notmandatory
left a comment
There was a problem hiding this comment.
tACK 90fd1a2
I manually tested the three esplora examples and they are all working fine.
| [dependencies] | ||
| bdk_core = { path = "../core", version = "0.3.0", default-features = false } | ||
| esplora-client = { version = "0.10.0", default-features = false } | ||
| esplora-client = { version = "0.11.0", default-features = false } |
Collaborator
There was a problem hiding this comment.
nit: there's a trailing whitespace here
Suggested change
| esplora-client = { version = "0.11.0", default-features = false } | |
| esplora-client = { version = "0.11.0", default-features = false } |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
bdk_esplorato depend on esplora-client 0.11.0Notes to the reviewers
bitcoindevkit/rust-esplora-client#103 added a generic type parameter to
AsyncClientrepresenting a user-definedSleeperand that change is reflected here in order to call the underlying API methods. We also add a new build feature "tokio" that enables the corresponding feature in rust-esplora-client.closes #1742
Changelog notice
bdk_esplora: Bumpesplora-clientto 0.11.0Checklists
All Submissions:
cargo fmtandcargo clippybefore committing