Skip to content

Remove serde json dependency from chain crate #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notmandatory merged 9 commits into from
Dec 9, 2024
Merged

Remove serde json dependency from chain crate #1752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b587b0f
refactor(chain)!: impl sqlite for ConfirmationBlockTime anchored chan…
nymius Nov 27, 2024
7319f51
refactor(chain)!: remove AnchorImpl wrapper for Anchor implementors
nymius Nov 28, 2024
d41cb62
build(chain): remove serde_json dependency
nymius Nov 29, 2024
c3ea54d
test(wallet): check persisted anchors does not lose data
nymius Nov 29, 2024
5603e9f
test(chain): use ChangeSet<ConfirmationBlockTime> instead of ChangeSe…
nymius Nov 29, 2024
2eb19f5
refactor(chain)!: move schemas to their own methods
nymius Dec 2, 2024
4ec7940
test(wallet): pattern match ChainPosition::Confirmed in anchors persi…
nymius Dec 2, 2024
265b59b
test(chain): add compatibility test for v0 to v1 sqlite schema migration
nymius Dec 4, 2024
1c81cd5
refactor(chain)!: change String by &str for versioned scripts in migr…
nymius Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/chain/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ miniscript = { version = "12.0.0", optional = true, default-features = false }

# Feature dependencies
rusqlite = { version = "0.31.0", features = ["bundled"], optional = true }
serde_json = { version = "1", optional = true }

[dev-dependencies]
rand = "0.8"
Expand All @@ -36,4 +35,4 @@ default = ["std", "miniscript"]
std = ["bitcoin/std", "miniscript?/std", "bdk_core/std"]
serde = ["dep:serde", "bitcoin/serde", "miniscript?/serde", "bdk_core/serde"]
hashbrown = ["bdk_core/hashbrown"]
rusqlite = ["std", "dep:rusqlite", "serde", "serde_json"]
rusqlite = ["std", "dep:rusqlite", "serde"]
24 changes: 0 additions & 24 deletions crates/chain/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,27 +100,3 @@ impl<T> core::ops::Deref for Impl<T> {
&self.0
}
}

/// A wrapper that we use to impl remote traits for types in our crate or dependency crates that impl [`Anchor`].
pub struct AnchorImpl<T>(pub T);

impl<T> AnchorImpl<T> {
/// Returns the inner `T`.
pub fn into_inner(self) -> T {
self.0
}
}

impl<T> From<T> for AnchorImpl<T> {
fn from(value: T) -> Self {
Self(value)
}
}

impl<T> core::ops::Deref for AnchorImpl<T> {
type Target = T;

fn deref(&self) -> &Self::Target {
&self.0
}
}
Loading