Skip to content

wallet: Bump bitcoin dependency to v0.32.4#1853

Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
stevenroose:bump-bitcoin-0.32.4
Feb 25, 2025
Merged

wallet: Bump bitcoin dependency to v0.32.4#1853
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom
stevenroose:bump-bitcoin-0.32.4

Conversation

@stevenroose
Copy link
Copy Markdown
Contributor

@stevenroose stevenroose commented Feb 25, 2025

This is required since we are using Network::Testnet4

Changelog notice

bdk_wallet:

  • deps: Bump bitcoin to 0.32.4

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

This is required since we are using Network::Testnet4
Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5553e8d

@ValuedMammal ValuedMammal added the dependencies Pull requests that update a dependency file label Feb 25, 2025
@ValuedMammal ValuedMammal added this to the 1.2.0 milestone Feb 25, 2025
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5553e8d

@ValuedMammal ValuedMammal merged commit 7f95f57 into bitcoindevkit:master Feb 25, 2025
@evanlinjin
Copy link
Copy Markdown
Member

evanlinjin commented Feb 28, 2025

Why is this required? It's a patch release of bitcoin so it should have happened automatically if you do cargo update in your project? I don't see the reason to force users to a later patch version (unless if there is a critical bug fix).

@ValuedMammal ValuedMammal mentioned this pull request Apr 3, 2025
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants