Skip to content

chore: remove bdk_wallet and update readme and ci workflow#1928

Merged
evanlinjin merged 2 commits intobitcoindevkit:masterfrom
notmandatory:chore/remove_wallet
Apr 10, 2025
Merged

chore: remove bdk_wallet and update readme and ci workflow#1928
evanlinjin merged 2 commits intobitcoindevkit:masterfrom
notmandatory:chore/remove_wallet

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Apr 5, 2025

Description

Removes the bdk_wallet crate from the workspace of this repo now that it's been moved to it's own repo.

Notes to the reviewers

I did a bit of extra cleanup on the README file. I replaced the crates list with a table that also includes badges for the crate version and docs. I also renamed the example-crates folder to simply examples, a nit of mine that I already fixed in the new bdk_wallet repo.

See: bitcoindevkit/bdk_wallet#18

Changelog notice

For the changelog for the next version of bdk_wallet:

  • The bdk_wallet crate has been removed from the bdk repository and move to it's own bdk_wallet repository.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Apr 5, 2025
@notmandatory notmandatory added the chore Non-coding related work label Apr 5, 2025
@notmandatory notmandatory moved this to Needs Review in BDK Wallet Apr 5, 2025
@notmandatory notmandatory added this to the 1.3.0 milestone Apr 5, 2025
Comment thread README.md Outdated
Comment thread README.md Outdated
@notmandatory notmandatory force-pushed the chore/remove_wallet branch from eefc1f9 to 1d7ad31 Compare April 5, 2025 03:25
Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1d7ad31

Copy link
Copy Markdown

@AmosOO7 AmosOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I run the cargo test command, couple functions are failing.

@luisschwab
Copy link
Copy Markdown
Member

@AmosOO7 running cargo test here shows no failures, and CI is also passing. Are you sure you checked out this PR?

@AmosOO7
Copy link
Copy Markdown

AmosOO7 commented Apr 7, 2025

@luisschwa yes I did that.

@luisschwab
Copy link
Copy Markdown
Member

Can you show the errors?

@AmosOO7
Copy link
Copy Markdown

AmosOO7 commented Apr 7, 2025

failures:
chained_mempool_tx_sync

test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 17.89s

error: test failed, to rerun pass -p bdk_electrum --test test_electrum

@luisschwab
Copy link
Copy Markdown
Member

This test passes for me. Can you show the full log?

@AmosOO7
Copy link
Copy Markdown

AmosOO7 commented Apr 7, 2025

test_log.txt

@AmosOO7
Copy link
Copy Markdown

AmosOO7 commented Apr 7, 2025

I also noticed the test flags different functions, I don't know why that is happening.

@AmosOO7
Copy link
Copy Markdown

AmosOO7 commented Apr 7, 2025

test_log2.txt

If you take a look at this log, it flags another function

@AmosOO7
Copy link
Copy Markdown

AmosOO7 commented Apr 8, 2025

Hello @luisschwab and @notmandatory,

I cloned the repo afresh, checked out the PR, compiled it, and ran cargo test, but I keep encountering errors.

Could you please share the steps you used for testing? I’d like to compare and see if I might be missing something.

Copy link
Copy Markdown
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1d7ad31

Copy link
Copy Markdown
Member

@luisschwab luisschwab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1d7ad31

Copy link
Copy Markdown
Contributor

@LagginTimes LagginTimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1d7ad31

Copy link
Copy Markdown

@AmosOO7 AmosOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1d7ad31

@evanlinjin evanlinjin merged commit 18b7d9c into bitcoindevkit:master Apr 10, 2025
17 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in BDK Wallet Apr 10, 2025
@ValuedMammal ValuedMammal mentioned this pull request Apr 30, 2025
39 tasks
@notmandatory notmandatory deleted the chore/remove_wallet branch May 26, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non-coding related work

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants