Skip to content

feat(chain): Add method for constructing TxGraph from a ChangeSet#1930

Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
uvuvuwu:tx-graph-from-changeset
Apr 10, 2025
Merged

feat(chain): Add method for constructing TxGraph from a ChangeSet#1930
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
uvuvuwu:tx-graph-from-changeset

Conversation

@uvuvuwu
Copy link
Copy Markdown
Contributor

@uvuvuwu uvuvuwu commented Apr 6, 2025 •
edited
Loading

Description

  • Added a from_changeset() function to TxGraph implementation
  • This function initializes a new TxGraph and applies the given ChangeSet
  • The method allows constructing a TxGraph directly from a ChangeSet,
    simplifying graph creation.

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@uvuvuwu uvuvuwu marked this pull request as draft April 6, 2025 22:56
@uvuvuwu uvuvuwu force-pushed the tx-graph-from-changeset branch from 1af7fe2 to 4f3f555 Compare April 6, 2025 23:33
@uvuvuwu uvuvuwu changed the title Implement from_changeset() for constructing TxGraph from a ChangeSet feat(chain): Add method for constructing TxGraph from a ChangeSet Apr 6, 2025
@uvuvuwu uvuvuwu marked this pull request as ready for review April 7, 2025 00:57
@uvuvuwu uvuvuwu marked this pull request as draft April 7, 2025 01:05
@uvuvuwu
feat(chain): Add method for constructing TxGraph from a ChangeSet
f68cfa8 
* Added a `from_changeset()` function to `TxGraph` implementation
* This function initializes a new `TxGraph` and applies the given `ChangeSet`
* The method allows constructing a `TxGraph` directly from a `ChangeSet`,
  simplifying graph creation.
@uvuvuwu uvuvuwu force-pushed the tx-graph-from-changeset branch from 4f3f555 to f68cfa8 Compare April 7, 2025 01:49
@uvuvuwu uvuvuwu marked this pull request as ready for review April 7, 2025 01:51
evanlinjin
evanlinjin approved these changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f68cfa8

@evanlinjin evanlinjin moved this to Done in BDK Chain Apr 7, 2025
@evanlinjin evanlinjin moved this from Done to Needs Review in BDK Chain Apr 7, 2025
LagginTimes
LagginTimes approved these changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@LagginTimes LagginTimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f68cfa8

AmosOO7
AmosOO7 approved these changes Apr 7, 2025
View reviewed changes
Copy link
Copy Markdown

@AmosOO7 AmosOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f68cfa8

@evanlinjin evanlinjin merged commit b707586 into bitcoindevkit:master Apr 10, 2025
21 of 22 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in BDK Chain Apr 10, 2025
@uvuvuwu uvuvuwu deleted the tx-graph-from-changeset branch April 12, 2025 04:07
@ValuedMammal ValuedMammal mentioned this pull request Apr 30, 2025
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

+2 more reviewers

@AmosOO7 AmosOO7 AmosOO7 approved these changes

@LagginTimes LagginTimes LagginTimes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@uvuvuwu uvuvuwu

Labels

None yet

Projects

BDK Chain
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@uvuvuwu @evanlinjin @AmosOO7 @LagginTimes