ci: Pin coverage toolchain to nightly-2025-11-27#2080
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Dec 10, 2025
Merged
ci: Pin coverage toolchain to nightly-2025-11-27#2080notmandatory merged 1 commit intobitcoindevkit:masterfrom
nightly-2025-11-27#2080notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
44b29cd to
fd3dfe8
Compare
nightly-2025-11-27
This fixes a CI failure resulting from use of rustc nightly with `llvm-cov`. refer to: https://github.com/bitcoindevkit/bdk/actions/runs/19946035484. As a workaround we change `code_coverage.yml` to set the toolchain to `nightly-2025-11-27` which is a version of the compiler that is known to work with `cargo-llvm-cov` at generating coverage reports.
fd3dfe8 to
0e8849c
Compare
6 tasks
thunderbiscuit
approved these changes
Dec 10, 2025
Member
thunderbiscuit
left a comment
There was a problem hiding this comment.
ACK 0e8849c.
I would maybe just open an issue to keep track of the use of nightly and remember to remove it once stuff upstream is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
code_coverage.ymlstarted failing as can be seen in a recent CI run. As a workaround I set the toolchain in the coverage workflow tonightly-2025-11-27which is the version of the compiler in use the last time there was a successful coverage run.The cause is unknown (to me) and likely doesn't originate from a crate in
bdk. Assuming that a fix can be found, we can eventually revert this or otherwise keep the toolchain incode_coverage.ymlup to date as needed.Changelog notice
Checklists
All Submissions: