refactor(tests): move TxTemplate from chain to testenv#2177
Open
tvpeter wants to merge 4 commits intobitcoindevkit:masterfrom
Open
refactor(tests): move TxTemplate from chain to testenv#2177tvpeter wants to merge 4 commits intobitcoindevkit:masterfrom
chain to testenv#2177tvpeter wants to merge 4 commits intobitcoindevkit:masterfrom
Conversation
tvpeter
requested review from
evanlinjin,
luisschwab and
oleonardolima
as code owners
3 tasks
3 tasks
Collaborator
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
cACK a5d9f41
You can rebase to get the latest toolchain updated CI. Overall looks good, I only would like to take a deeper look into the last commit.
Collaborator
Also, I'd avoid mixing renaming and moving code in the same commits. |
- move tx_template from chain to testenv - update imports from chain/common/ to bdk_testenv /tx_template/
-update TxTemplate struct to use Cow pointer - add utility methods to TxTemplate
- update test_tx_graph and test_tx_graph_conflicts to use builder API
tvpeter
force-pushed
the
refactor/mv-txtemplate-to-testenv
branch
from
a5d9f41 to
6d5cac1
Compare
Collaborator
|
@tvpeter Oh, there are some conflicts 😅 |
Collaborator
Author
Yeah, from the recent merge. I will rebase and resolve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the
TxTemplatefrom thechaincrate into thetestenv. It also updates theTxTemplateto use theCowsmart pointer, adds method implementations toTxTemplate, and migrates tests to the builder API.This PR addresses the first and second todos on #1936.
Changelog notice
TxTemplatefrom chain to testenvChecklists
All Submissions: