[wallet] Fix details.fees being wrong when change is dust#255
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jan 4, 2021
Merged
[wallet] Fix details.fees being wrong when change is dust#255notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
6 tasks
Member
|
ACK 0c9c071 nice catch, I double checked that |
Member
|
ACK 0c9c071 Sorry it took me a while to answer, I decided to take a break after the release to relax and distract myself a little bit.. Over the next few days I'll start working regularly like I was doing before |
Collaborator
Author
|
Thanks. @afilini No rush whatsoever. I hope you all had a great break. |
nickfarrow
pushed a commit
to nickfarrow/bdk
that referenced
this pull request
Feb 21, 2022
…(Pr 2 of 3) 42e4c50 Cleanup context code with SigType enum (sanket1729) e70e6a3 Fix fuzzer crash while allocating keys for multi_a (sanket1729) f6b2536 Add satisfaction tests (sanket1729) 1a7e779 Change satisfier to support xonly sigs (sanket1729) 2c32c03 Use bitcoin::SchnorrSig type from rust-bitcoin (sanket1729) e26d4e6 Use bitcoin::EcdsaSig from rust-bitcoin (sanket1729) 89e7cb3 add multi_a (sanket1729) Pull request description: Adds support for MultiA script fragment. Builds on top of bitcoindevkit#255 . Do not merge this until we have a rust-bitcoin release ACKs for top commit: apoelstra: ACK 42e4c50 Tree-SHA512: 10701266cf6fe436fe07359e67d16bc925ebbcd767d4e5a8d325db61b979bd76b1e0291dd9eae5b7d58f6a385f8f2e16c2657957a597ce18736382b776e20502
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bug I found while doing other things. The
TransactionDetailsfeefield will be wrong if the change is omitted because it's below the dust threshold.All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: