Update create transaction example code#340
Update create transaction example code#340tcharding wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
|
Looks like they are being ignored for some reason, can you also change them to I did a quick test and there's also another test failing on line 145 which can be trivially fixed (replace |
|
Thanks for the review, will fix as suggested. |
The transaction builder changed a while ago, looks like some of the example code did not get updated. Update the transaction creation code to use a mutable builder.
We have an attribute `no_run` that builds but does not run example code in Rustdocs, this keeps the examples building as the codebase evolves. use `no_run` and fix example code so it builds cleanly during test run.
Since we are cleaning up the example code in `lib.rs`; use the `bdk` project imports stlye in the example code i.e., separate upstream imports form bdk/crate imports.
|
@afilini I fixed as suggested including changing all |
|
I think the CI is failing because the tests use the electrum stuff but they are not feature-gated. It's kinda ugly but there's a way to fix it: Lines 453 to 472 in 12641b9 |
|
Since we have to do the release today and this isn't ready yet I've cherry-picked abbea4b on the release branch, so at least we will have the correct example on the published crate |
|
Wow, this opens a whole can of worms. The I don't have the inclination to dig further into this at the moment. Closing this issue for another day. |
Description
The transaction builder changed a while ago, looks like some of the example code did not get updated.
Update the transaction creation code to use a mutable builder.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing