Change the visibility of the derived module and of the AsDerived trait#520
Closed
w0xlt wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Change the visibility of the derived module and of the AsDerived trait#520w0xlt wants to merge 1 commit intobitcoindevkit:masterfrom
derived module and of the AsDerived trait#520w0xlt wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Currently this module is visible only in the crate, so it can't be accessed externally.
Collaborator
|
I happened to need this feature for I think this is a better way to do this. I'll see if I can clean up this commit and upstream it. |
Collaborator
|
Here I've made a PR that allows you to do this: #522 |
Contributor
|
ACK, #522 is much cleaner way to do it. |
Contributor
Author
|
Agree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no way to retrieve change addresses, so this PR changes the visibility of the
derivedmodule and theAsDerivedtrait.With this change, the addresses can be retrieved using the function below, for example: