update AddressInfo struct

[Eunoia1729]

Description

Resolves #541.

• Updates AddressInfo struct to include keychainKind
• Updates the related get_address functions to pass in this field
• Updates corresponding tests

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[rajarshimaitra]

tACK aa8c8f9

[notmandatory]

Looks good! can you also add a new test to verify the KeychainKind changes for an internal address? A new function was added in the last release to let you do this:
https://docs.rs/bdk/latest/bdk/wallet/struct.Wallet.html#method.get_internal_address

[ricknjacky]

LGTM!

[Eunoia1729]

Looks good! can you also add a new test to verify the KeychainKind changes for an internal address? A new function was added in the last release to let you do this: https://docs.rs/bdk/latest/bdk/wallet/struct.Wallet.html#method.get_internal_address

@notmandatory Thanks for the review !
Can I expand the existing tests instead of adding new ones ?
For example: I'm planning of expanding this test to assert the keyChainKind field as well along with address field. My reasoning behind this is to not increase the number of tests.

[rajarshimaitra]

@Eunoia1729 I think the best thing to do here is modify the get_address test

bdk/src/wallet/mod.rs

Line 3988 in 3334c8d

fn test_get_address() {

and change all the asserts into full structure matching, instead of just the address strings..

[Eunoia1729]

@Eunoia1729 I think the best thing to do here is modify the get_address test

Makes sense. Thanks for the inputs, @rajarshimaitra !
I've updated accordingly.

[rajarshimaitra]

ReACK e277ac8

[notmandatory]

ACK e277ac8

[notmandatory]

Looks like Github glitched and didn't run the tests which prevents me from merging. @Eunoia1729 can you maybe try force pushing your branch again, or if that doesn't trigger CI you may need to amend you last commit message and then try force pushing that. Thanks!

[Eunoia1729]

can you maybe try force pushing your branch again

@notmandatory Sure, done !