Add sqlite-bundled feature#566
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Mar 30, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
- Coverage 73.26% 73.26% -0.01%
==========================================
Files 35 35
Lines 7586 7581 -5
==========================================
- Hits 5558 5554 -4
+ Misses 2028 2027 -1
Continue to review full report at Codecov.
|
notmandatory
added a commit
to bitcoindevkit/bdk-ffi
that referenced
this pull request
Mar 14, 2022
12f4784 Add sqlite database option (Steve Myers) Pull request description: ### Description Add sqlite db database option. ### Notes to the reviewers When bitcoindevkit/bdk#566 is released we need to updated this project to use the `sqlite-packaged` feature, see TODO in Cargo.toml. ACKs for top commit: thunderbiscuit: Tested ACK [12f4784](12f4784). Tree-SHA512: c39472507596e036dd81c22a05d424c6d363545b1a8bd622bf9647967b1b86ab44764da1a15169ac542c80a62a79331b5abcda7b657cc28d93ffdda51a62bd6e
notmandatory
force-pushed
the
sqlite_bundled
branch
from
6614ff7 to
c6eeb7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
sqlite-bundledfeature for deployments that need a bundled version of sqlite, ie. for mobile platforms. This feature enables therusqlitebundledfeature.Notes to the reviewers
The bundled version of sqlite is required for cross-compiling bdk with sqlite for mobile devices because we don't have the sqlite lib to link to for the mobile platforms. Using the bundled feature builds and links a recent version of sqlite.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md