Fix pre-segwit inputs with esplora#571
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Mar 17, 2022
Merged
Conversation
|
It's funny how the fix was just one small change. Good test, and really good discovery about Esplora, thanks for doing that resarch. I only found it because I went pleb mode on a few faucets around the web, and I have a test that makes a transaction to myself using my personal testnet wallet in CI. LGTM, Let's Get This Merged! |
Member
|
This looks important enough to cherry-pick into the |
notmandatory
added a commit
to bitcoindevkit/rust-esplora-client
that referenced
this pull request
Aug 2, 2022
e0d8dab Fix pre-segwit inputs with esplora (LLFourn) Pull request description: Unexpectedly pre-segwit inputs have an empty JSON witness field in esplora. Fixes #570 * [x] I've added tests to reproduce the issue which are now passing * [x] I'm linking the issue being fixed by this PR ACKs for top commit: notmandatory: ACK e0d8dab afilini: ACK e0d8dab Tree-SHA512: 1da82aeb2739111e1a516d94c79fe7d7c7879526a8cd780dcd63ff5ae9ccb1bed4eb20e5c575a45e37b6d1818d63ce6d3812e7b9ae34ebb02bc190a47b9750f8
chrono-raven6i90
added a commit
to chrono-raven6i90/rust-esplora-client
that referenced
this pull request
Oct 28, 2025
e0d8dab198813fdc2dd2f72f8495e8c43fc355e4 Fix pre-segwit inputs with esplora (LLFourn)
Pull request description:
Unexpectedly pre-segwit inputs have an empty JSON witness field in esplora.
Fixes #570
* [x] I've added tests to reproduce the issue which are now passing
* [x] I'm linking the issue being fixed by this PR
ACKs for top commit:
notmandatory:
ACK e0d8dab198813fdc2dd2f72f8495e8c43fc355e4
afilini:
ACK e0d8dab198813fdc2dd2f72f8495e8c43fc355e4
Tree-SHA512: 1da82aeb2739111e1a516d94c79fe7d7c7879526a8cd780dcd63ff5ae9ccb1bed4eb20e5c575a45e37b6d1818d63ce6d3812e7b9ae34ebb02bc190a47b9750f8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unexpectedly pre-segwit inputs have an empty JSON witness field in esplora.
Fixes #570