Skip to content

Fix CI, bump MSRV to 1.56.1#638

Merged
afilini merged 1 commit intobitcoindevkit:masterfrom
danielabrozzoni:fix_ci
Jun 27, 2022
Merged

Fix CI, bump MSRV to 1.56.1#638
afilini merged 1 commit intobitcoindevkit:masterfrom
danielabrozzoni:fix_ci

Conversation

@danielabrozzoni
Copy link
Copy Markdown
Member

@danielabrozzoni danielabrozzoni commented Jun 21, 2022

Description

This PR fixes the CI, which is currently failing after a Github Actions update.
The MSRV is bumped to 1.56.1 (from 1.56.0), since that's reqwest's current MSRV.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@danielabrozzoni danielabrozzoni force-pushed the fix_ci branch 3 times, most recently from 8366488 to 1172a98 Compare June 21, 2022 15:29
@danielabrozzoni danielabrozzoni marked this pull request as ready for review June 22, 2022 07:31
@danielabrozzoni danielabrozzoni changed the title Fix CI Update CI, bump MSRV to 1.56.1 Jun 22, 2022
@danielabrozzoni danielabrozzoni changed the title Update CI, bump MSRV to 1.56.1 Fix CI, bump MSRV to 1.56.1 Jun 22, 2022
@danielabrozzoni danielabrozzoni force-pushed the fix_ci branch 2 times, most recently from d265c49 to 2cd5dfd Compare June 22, 2022 07:37
@danielabrozzoni danielabrozzoni force-pushed the fix_ci branch 2 times, most recently from fb96833 to 79e958f Compare June 22, 2022 16:09
@danielabrozzoni danielabrozzoni self-assigned this Jun 23, 2022
@danielabrozzoni danielabrozzoni force-pushed the fix_ci branch 2 times, most recently from fbfedfa to cf8b4fe Compare June 27, 2022 10:20
In this way we can continue using reqwest v0.11, whose MSRV is now
1.56.1
The only difference between v1.56.0 and v1.56.1 is a bug fix for
CVE-2021-42574.
@danielabrozzoni danielabrozzoni force-pushed the fix_ci branch 2 times, most recently from ac67245 to b289c4e Compare June 27, 2022 11:04
Copy link
Copy Markdown
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b289c4e

@afilini afilini merged commit 5c566bb into bitcoindevkit:master Jun 27, 2022
@danielabrozzoni danielabrozzoni mentioned this pull request Jun 28, 2022
6 tasks
@danielabrozzoni danielabrozzoni deleted the fix_ci branch August 16, 2022 17:06
@danielabrozzoni danielabrozzoni restored the fix_ci branch August 16, 2022 17:06
@danielabrozzoni danielabrozzoni deleted the fix_ci branch August 16, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants