Skip to content

Allow signing only specific leaf hashes#645

Merged
afilini merged 1 commit intobitcoindevkit:masterfrom
danielabrozzoni:616_leaf_hash_sign
Aug 2, 2022
Merged

Allow signing only specific leaf hashes#645
afilini merged 1 commit intobitcoindevkit:masterfrom
danielabrozzoni:616_leaf_hash_sign

Conversation

@danielabrozzoni
Copy link
Copy Markdown
Member

@danielabrozzoni danielabrozzoni commented Jun 30, 2022

Fixes #616

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

@danielabrozzoni danielabrozzoni requested a review from afilini June 30, 2022 13:39
@danielabrozzoni danielabrozzoni force-pushed the 616_leaf_hash_sign branch 2 times, most recently from d214801 to b8459a8 Compare July 13, 2022 12:42
afilini
afilini reviewed Jul 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, but I would also add a way to disable signing for the internal key (which is required if you want to force the use of a a script-spend path)

@notmandatory notmandatory added the new feature New feature or request label Jul 16, 2022
@danielabrozzoni danielabrozzoni mentioned this pull request Jul 18, 2022
Closed
22 tasks
@danielabrozzoni danielabrozzoni force-pushed the 616_leaf_hash_sign branch 3 times, most recently from e6ba47c to 7e1a87a Compare July 20, 2022 09:30
@danielabrozzoni
Copy link
Copy Markdown
Member Author

danielabrozzoni commented Jul 20, 2022

I would also add a way to disable signing for the internal key (which is required if you want to force the use of a a script-spend path)

Done :)

@danielabrozzoni
Copy link
Copy Markdown
Member Author

danielabrozzoni commented Jul 30, 2022

Rebased

afilini
afilini reviewed Aug 2, 2022
View reviewed changes
Comment thread src/wallet/signer.rs Outdated
Comment thread src/wallet/signer.rs Outdated
@danielabrozzoni
Better customize signing in taproot transactions
a713a5a 
We would previously always try to sign with the taproot internal
key, and try to sign all the script leaves hashes.
Instead, add the `sign_with_tap_internal_key` and `TapLeaveOptions`
parameters, to be able to specify if we should sign with the internal
key, and exactly which leaves we should sign.
Fixes bitcoindevkit#616
@danielabrozzoni
Copy link
Copy Markdown
Member Author

danielabrozzoni commented Aug 2, 2022

Fixed

afilini
afilini approved these changes Aug 2, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a713a5a

@afilini afilini merged commit 5a41597 into bitcoindevkit:master Aug 2, 2022
@danielabrozzoni danielabrozzoni deleted the 616_leaf_hash_sign branch August 16, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afilini afilini afilini approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels

new feature New feature or request

Projects

None yet

Milestone

Release 0.21.0 Feature Freeze

Development

Successfully merging this pull request may close these issues.

Allow signing only specific leaf hashes

3 participants

@danielabrozzoni @afilini @notmandatory