rpc: manually add the immature utxos to the db#687
Closed
danielabrozzoni wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
rpc: manually add the immature utxos to the db#687danielabrozzoni wants to merge 1 commit intobitcoindevkit:masterfrom
danielabrozzoni wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Before this commit, the rpc backend wouldn't notice the immature utxos (listunspent doesn't return them), making the rpc balance different from the other backend's balance.
afilini
reviewed
Jul 28, 2022
Comment on lines
+301
to
+302
| // FIXME: This will produce a wrong result if the immature utxo is spent, | ||
| // which *should* be impossible. |
Member
There was a problem hiding this comment.
I don't think this warning is necessary, it's impossible to spend immature stuff
| .detail | ||
| .address | ||
| .as_ref() | ||
| .expect("Should always be here") |
Member
There was a problem hiding this comment.
Some descriptors are encoded as scripts that don't have an address form, so I don't think it's safe to expect here
Member
|
@danielabrozzoni I'm currently butchering the I'll be completely revamping the portion of code you are working with in this PR... I'm not sure what the best approach would be right now 😅 I'm currently online on Discord if you would like to discuss. |
8 tasks
Member
|
This PR is currently replaced by #683 (unless if reviews say otherwise) |
Member
Author
Agreed, I'm closing this for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the rpc backend wouldn't notice the immature
utxos (listunspent doesn't return them), making the rpc balance
different from the other backend's balance.
Description
Notes to the reviewers
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.mdBugfixes: