Add allow_dust method to TxBuilder#689
Conversation
|
Concept ACK! Transactions with below-dust ouputs are non-standard, but still valid, so I think BDK should be able to create them. It could also be useful in some very rare cases, like for creating a notification output to an address. |
|
The code looks good to me, can you please squash all the commits into the first one? |
|
Mh... There are still two commits, and the latest one's message is a bit weird. I'd use interactive git rebases to fix (https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History) - I would reword the first commit to change the message, and drop entirely the second commit |
@danielabrozzoni Should be good to go now. PTAL |
rajarshimaitra
left a comment
rajarshimaitra
left a comment
There was a problem hiding this comment.
Review ACK.. Code looks good to me.. A small test at this stage would be really nice..
|
@rajarshimaitra do you have in mind any other additional test? There's already a |
rajarshimaitra
left a comment
rajarshimaitra
left a comment
There was a problem hiding this comment.
tACK 61ad455
Huh.. I have no idea how I missed the test in last pass.. Thanks @danielabrozzoni yup thats all, we don't need anything else..
This looks good to go..
| - Change the meaning of the `fee_amount` field inside `CoinSelectionResult`: from now on the `fee_amount` will represent only the fees asociated with the utxos in the `selected` field of `CoinSelectionResult`. | ||
| - New `RpcBlockchain` implementation with various fixes. | ||
| - Return balance in separate categories, namely `confirmed`, `trusted_pending`, `untrusted_pending` & `immature`. | ||
| - Add `allow_dust` method on `TxBuilder`. |
There was a problem hiding this comment.
You should rebase and move this under the new unreleased section
There was a problem hiding this comment.
Hey @terror, sorry for the ping, but the feature freeze is tomorrow, which means that if you fix this comment by tomorrow we can merge the PR and release allow_dust as a part of bdk 0.22! :)
|
Oh no, I just noticed... @terror can you sign your commit? Otherwise I can't merge. If you prefer, I can sign it with my key. |
Add TxBuilder::allow_dust() that skips checking the dust limit
|
tACK bfd7b2f |
5 participants
We needed this for testing our wallet with dust, does this look like a reasonable feature? If so, I'll go ahead and add a test, update the changelog, etc.