Retry failed RPC calls on error#707
Closed
afilini wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Conversation
bfe86cd to
9aa08ed
Compare
Whenever the transport errors with "WouldBlock" we wait a bit and retry the call. Related to bitcoindevkit#650, should at least fix the errors with RPC
9aa08ed to
ccb951a
Compare
Member
4 tasks
Member
|
Closing this for now as this deals with legacy code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Whenever the transport errors with "WouldBlock" we wait a bit and retry the call.
This partially fixes #650, at least the errors happening with the RPC blockchain reported here: #650 (comment)
Notes to the reviewers
I'm a bit puzzled because in my tests I still have failures, but this time with the error:
even though the wallet have just been created. I even tried adding another "await_wallet_scan" before our
importdescriptorsand it didn't make any difference.To consistently reproduce this issue I ran the tests in a large (>=16 vCPUs) instance on AWS.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.mdBugfixes: