[bug-fix] Set the db sync height#726
Conversation
79759c8 to
42a0587
Compare
|
Updated with review comments.. |
42a0587 to
b8ce842
Compare
|
Thanks @vladimirfomene for the catches.. Updated.. |
fdf1f5c to
a72a97b
Compare
|
Thanks @afilini for the look.. Updated as suggested.. In the last dev call we talked about releasing this as a patch version for some downstream libs to update.. See bitcoindevkit/bdk-cli#102 (comment) |
|
Sorry I didn't notice the two issues that Alekos has found, I should have inspected the code better. re-utACK a72a97b |
|
@rajarshimaitra even though we talked about doing a fix release for this, since this is a test framework fix and code freeze for 0.22 is next Wed. (Aug 31), can we skip doing a fix release only for this PR and wait for 0.22 to put it out (Sept 7)? |
|
@notmandatory sounds good to me.. Only needed for the bdk-cli PR.. That can wait a bit.. |
Previously we weren't setting the db sync height in populate_test_db macro even when current height is provided.. This creates a bug that get_funded_wallet will return 0 balance. This PR fixes the populate_test_db macro and updates tests which were previously dependent on the unsynced wallet behavior.
a72a97b to
08668ac
Compare
|
Updated and rebased.. |
Description
Fixes #719
Previously we weren't setting the db sync height in populate_test_db
macro even when current height is provided.. This creates a bug that
get_funded_wallet will return 0 balance.
This PR fixes the populate_test_db macro and updates tests which were
previously dependent on the unsynced wallet behavior.
Notes to the reviewers
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: