Skip to content

Add HWI example in docs#758

Merged
afilini merged 4 commits intobitcoindevkit:masterfrom
danielabrozzoni:hwi_docs
Oct 24, 2022
Merged

Add HWI example in docs#758
afilini merged 4 commits intobitcoindevkit:masterfrom
danielabrozzoni:hwi_docs

Conversation

@danielabrozzoni
Copy link
Copy Markdown
Member

@danielabrozzoni danielabrozzoni commented Sep 19, 2022 •
edited
Loading

Description

Notes to the reviewers

Changelog notice

  • bdk re-exports the hwi create when the feature hardware-signer is on
  • Add examples/hardware_signer.rs

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@danielabrozzoni danielabrozzoni self-assigned this Sep 19, 2022
afilini
afilini reviewed Sep 22, 2022
View reviewed changes
Comment thread src/wallet/hardwaresigner.rs Outdated
Comment thread src/wallet/hardwaresigner.rs Outdated
Comment thread src/wallet/hardwaresigner.rs Outdated
@danielabrozzoni
Copy link
Copy Markdown
Member Author

danielabrozzoni commented Sep 26, 2022

Moving this to the 0.24 milestone, as I need to tag the newest hwi first (I need bitcoindevkit/rust-hwi@ab07d13)

@danielabrozzoni
Copy link
Copy Markdown
Member Author

danielabrozzoni commented Oct 4, 2022

Tagging hwi will take some time, putting this in draft

@danielabrozzoni danielabrozzoni marked this pull request as draft October 4, 2022 10:31
@notmandatory notmandatory mentioned this pull request Oct 10, 2022
Closed
26 tasks
@notmandatory notmandatory removed this from the Release 0.24.0 Feature Freeze milestone Oct 11, 2022
@danielabrozzoni danielabrozzoni marked this pull request as ready for review October 12, 2022 13:32
@danielabrozzoni
Copy link
Copy Markdown
Member Author

danielabrozzoni commented Oct 12, 2022

Sorry if this PR was in a rather crappy state @afilini. It should definitely be better now! :)

@danielabrozzoni
Update the hardwaresigner module documentation
1a71eb1 
Add a little example on how to use the HWISigner, slightly improve
the module description
@danielabrozzoni
Add the hardware_signer example
1437e1e
afilini
afilini approved these changes Oct 24, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1437e1e

@afilini afilini merged commit ea47d7a into bitcoindevkit:master Oct 24, 2022
@notmandatory notmandatory mentioned this pull request Oct 27, 2022
Closed
24 tasks
@danielabrozzoni danielabrozzoni deleted the hwi_docs branch October 11, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afilini afilini afilini approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels

None yet

Projects

None yet

Milestone

Release 0.24.0 Feature Freeze

Development

Successfully merging this pull request may close these issues.

3 participants

@danielabrozzoni @afilini @notmandatory