Add signature grinding for ECDSA signatures#779
Merged
danielabrozzoni merged 1 commit intobitcoindevkit:masterfrom Oct 17, 2022
Merged
Conversation
vladimirfomene
force-pushed
the
implement-signature-grinding
branch
2 times, most recently
from
1d07269 to
2b1e239
Compare
Member
danielabrozzoni
left a comment
danielabrozzoni
left a comment
There was a problem hiding this comment.
Concept ACK, the code looks good to me!
Contributor
rajarshimaitra
left a comment
rajarshimaitra
left a comment
There was a problem hiding this comment.
ACK.. Code LGTM..
This PR adds a new field called `allow_grinding` in the Signer's `SignOptions` struct that is used to determine whether or not to grind an ECDSA signature during the signing process.
vladimirfomene
force-pushed
the
implement-signature-grinding
branch
from
2b1e239 to
68dd6d2
Compare
Member
|
ACK 68dd6d2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new field called
allow_grindingin the Signer's
SignOptionsstruct that is usedto determine whether or not to grind an ECDSA signature during the signing process.
Changelog notice
Breaking change: the BDK Signer now produces low-R signatures by default, saving one byte. If you want to preserve the original behavior, set
allow_grindingin theSignOptionstofalse.Notes to the reviewers
This PR resolves issue #695
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: