Skip to content

Fix wallet export rescan height#785

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
LLFourn:fix-wallet-export-height
Nov 22, 2022
Merged

Fix wallet export rescan height#785
notmandatory merged 1 commit intobitcoindevkit:masterfrom
LLFourn:fix-wallet-export-height

Conversation

@LLFourn
Copy link
Copy Markdown
Collaborator

@LLFourn LLFourn commented Oct 26, 2022

It would return the latest transaction height rather than the earliest as the height to rescan from.

Found by @evanlinjin and I while implementing bdk_core stuff into bdk's wallet.

Changelog notice

  • Fix wallet export transaction height

All Submissions:

  • I've signed all my commits
  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing

It would return the latest transaction height rather than the earliest :S
@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Nov 7, 2022

The Changelog notice section is where you'd put what ever change log message (if any) you want put in the release notes changelog (which we now manually put together and add to the release tag and on Github releases page).

Copy link
Copy Markdown
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK e9bbb87

Yup makes sense to export the "sync from" height rather than last seen height..

Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e9bbb87

@notmandatory notmandatory merged commit 108edc3 into bitcoindevkit:master Nov 22, 2022
@notmandatory notmandatory added the bug Something isn't working label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants