Remove deprecated code and feature aliases#796
Closed
notmandatory wants to merge 5 commits intobitcoindevkit:masterfrom
Closed
Remove deprecated code and feature aliases#796notmandatory wants to merge 5 commits intobitcoindevkit:masterfrom
notmandatory wants to merge 5 commits intobitcoindevkit:masterfrom
Conversation
notmandatory
force-pushed
the
remove_deprecated
branch
from
159d474 to
d54228c
Compare
notmandatory
modified the milestones:
Release 0.25.0 Feature Freeze,
Release 0.26.0 Feature Freeze
Member
Author
|
This isn't urgent so moving to the 0.26 release |
22 tasks
Member
Author
|
Closing this, it's a lot to review and can be done as part of the bdk_core 1.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A little housekeeping to remove recent and older deprecated code and feature aliases.
Notes to the reviewers
I also removed the descriptor checksum inception check and corresponding test since the ability to make bad checksums was deprecated and now removed.
Changelog notice
Removed deprecated
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing