fix: ensure the key network is updated in the KeyMap as well#800
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Nov 24, 2022
Merged
Conversation
Otherwise we may have inconsistencies with keys in the descriptor that have a network and keys in the keymap that are different.
afilini
force-pushed
the
fix/internal-key-network
branch
from
c380adf to
150f4d6
Compare
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Otherwise we may have inconsistencies with keys in the descriptor that have a network and keys in the keymap that are different.
Notes to the reviewers
Adding it to the
0.25milestone since it's just a quick fixChecklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: