fix: make save_tx order independent#808
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Dec 16, 2022
Merged
Conversation
notmandatory
approved these changes
Nov 30, 2022
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK 37c2eb4
Thanks for this fix. I'm also working on adding Fulcrum into our electrum integration tests suite. But I'll do that as a separate PR.
Member
|
One more thing, can you sign and re-push your commit? It's one of our merge rules. |
22 tasks
Member
|
This should be ready to merge once #822 goes in. |
Member
|
Hi, please rebase this one to pick up the CI fix which is required to merge. Thanks! |
notmandatory
force-pushed
the
fix-electrum-tx-order
branch
from
37c2eb4 to
d72aa7e
Compare
Member
|
I checked with @bodymindarts and he's tied up with end of year stuff so I went ahead and rebased this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fulcrum doesn't return txs in the order they are requested in. This PR makes the
TxCacheinsensitive to this behaviour.