Skip to content

Fix wrong key origin path in public descriptor templates#818

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
yukibtc:fixwrongkeypath
Dec 16, 2022
Merged

Fix wrong key origin path in public descriptor templates#818
notmandatory merged 1 commit intobitcoindevkit:masterfrom
yukibtc:fixwrongkeypath

Conversation

@yukibtc
Copy link
Copy Markdown
Contributor

@yukibtc yukibtc commented Dec 9, 2022

Description

Fixes #817

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory added the bug Something isn't working label Dec 14, 2022
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 703ad89

@notmandatory
Copy link
Copy Markdown
Member

This will be ready to merge after #822 goes in.

@notmandatory
Copy link
Copy Markdown
Member

Hi, please rebase this one to pick up the CI fix which is required to merge. Thanks!

@yukibtc
Copy link
Copy Markdown
Contributor Author

yukibtc commented Dec 14, 2022

Hi, please rebase this one to pick up the CI fix which is required to merge. Thanks!

Rebased :)

@notmandatory notmandatory merged commit 0b768d6 into bitcoindevkit:master Dec 16, 2022
@yukibtc yukibtc deleted the fixwrongkeypath branch December 16, 2022 21:46
@notmandatory notmandatory mentioned this pull request Dec 26, 2022
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public descriptor templates for xkeys have wrong key origin path

2 participants