Make README.md code examples compile without errors#820
Merged
danielabrozzoni merged 1 commit intobitcoindevkit:masterfrom Dec 15, 2022
Merged
Make README.md code examples compile without errors#820danielabrozzoni merged 1 commit intobitcoindevkit:masterfrom
danielabrozzoni merged 1 commit intobitcoindevkit:masterfrom
Conversation
evanlinjin
approved these changes
Dec 13, 2022
|
|
||
| use base64; | ||
| use bitcoin::consensus::serialize; | ||
| use bdk::bitcoin::consensus::serialize; |
Member
There was a problem hiding this comment.
Why is this needed? The example runs just fine for me without it
Contributor
Author
|
On December 13, 2022 2:01:07 AM CST, Daniela Brozzoni ***@***.***> wrote:
@danielabrozzoni commented on this pull request.
> @@ -96,14 +97,15 @@ use bdk::electrum_client::Client;
use bdk::wallet::AddressIndex::New;
use base64;
-use bitcoin::consensus::serialize;
+use bdk::bitcoin::consensus::serialize;
Why is this needed? The example runs just fine for me without it
.
Because you have `bitcoin` as a dependency as well as `bdk`; with my change you can run the example with just `bdk` in your `Cargo.toml`
|
danielabrozzoni
approved these changes
Dec 13, 2022
Member
There was a problem hiding this comment.
Because you have
bitcoinas a dependency as well asbdk; with my change you can run the example with justbdkin yourCargo.toml
Oh right, I noticed that but I misread that line and thought you were introducing a new import 😅
ACK 99e7037
Member
|
Looks like this is ready to go after I get #822 in to fix the nightly docs CI error. |
Member
|
I merged #822, try rebasing plz :) (I can't merge until CI passes) |
petertodd
force-pushed
the
2022-11-readme-examples
branch
from
99e7037 to
dea211d
Compare
petertodd
force-pushed
the
2022-11-readme-examples
branch
from
dea211d to
d1e5b87
Compare
Contributor
Author
|
On Wed, Dec 14, 2022 at 11:19:46AM -0800, Daniela Brozzoni wrote:
I merged #822, try rebasing plz :) (I can't merge until CI passes)
Rebased
|
Member
|
ACK d1e5b87 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.