Derive PartialEq, Eq on SyncTime#837
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jan 30, 2023
Merged
Conversation
Member
|
Looks good, we just changed our CI MSRV so you'll need to do a rebase to pick that up. |
23 tasks
This enables e.g. `assert_eq!` comparisons of `SyncTime` in tests.
MaxFangX
force-pushed
the
synctime-derive
branch
from
713472f to
45d4141
Compare
Contributor
Author
|
@notmandatory rebased, awaiting approval again for running CI |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This enables e.g.
assert_eq!comparisons ofSyncTimein tests (we use this)Changelog notice
Derived
PartialEq,EqonSyncTimeAll Submissions:
cargo fmtandcargo clippybefore committing