Set dev-dependency base64ct version to <1.6.0#877
Merged
notmandatory merged 1 commit intobitcoindevkit:release/0.27from Mar 7, 2023
Merged
Set dev-dependency base64ct version to <1.6.0#877notmandatory merged 1 commit intobitcoindevkit:release/0.27from
notmandatory merged 1 commit intobitcoindevkit:release/0.27from
Conversation
notmandatory
force-pushed
the
fix/base64ct_msrv
branch
from
4efb22a to
616b914
Compare
notmandatory
force-pushed
the
fix/base64ct_msrv
branch
from
616b914 to
b111f97
Compare
rajarshimaitra
approved these changes
Mar 7, 2023
Contributor
rajarshimaitra
left a comment
rajarshimaitra
left a comment
There was a problem hiding this comment.
tACK b111f97
Tried all the tests manually.. Looks good..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes CI for MSRV 1.57.0.
In the past we fixed our dev-dependency for
zip(used byelectrsd) to version 1.6.3 which has an MSRV of 1.57, butzipdepends onbase64ctwhich with it's 1.6.0 version changed it's MSRV to 1.60.0. This PR pins the dev-dependencybase64ctto less than version 1.6.0 so that we can keep our project MSRV at 1.57.Notes to the reviewers
The MSRV issues caused by the
electrsdcrate are getting a bit out of hand but should get better when we have electrum and other blockchain clients in different crates that can have higher MSRVs than the corebdk_chaincrate.Changelog notice
None.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing