Skip to content

Nit fixes on documentation#888

Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
rajarshimaitra:greamarly-fixes
Mar 15, 2023
Merged

Nit fixes on documentation#888
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
rajarshimaitra:greamarly-fixes

Conversation

@rajarshimaitra
Copy link
Copy Markdown
Contributor

Description

This builds on #793 and adds documentation fixes for the alpha release. It mainly includes typos, sentence constructions, and punctuations. Fixes are reported by Grammarly. Only fixed files are modules added from bdk_core. Previous bdk modules are untouched.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added this to the 1.0.0-alpha.0 milestone Mar 10, 2023
@notmandatory
Copy link
Copy Markdown
Member

This can be rebased now to master since #793 is merged.

Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 24df03a

Thanks for the work! I rebased this on top of master also.

Copy link
Copy Markdown
Contributor Author

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @evanlinjin already rebased..

ACK 24df03a

@evanlinjin evanlinjin merged commit 82f5d9c into bitcoindevkit:master Mar 15, 2023
@notmandatory notmandatory mentioned this pull request Mar 20, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants