Add docs for EsploraAsyncExt and make doctests runnable#889
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom Mar 17, 2023
Merged
Conversation
evanlinjin
force-pushed
the
add-async-syncing-esplora
branch
2 times, most recently
from
261ca73 to
136a0b1
Compare
evanlinjin
force-pushed
the
add-async-syncing-esplora
branch
from
136a0b1 to
2c4d9e1
Compare
evanlinjin
force-pushed
the
add-async-syncing-esplora
branch
from
2c4d9e1 to
877b658
Compare
|
@evanlinjin Great work on this PR! Considering the increasing adoption of Miniscript for expressive and secure policy construction in Bitcoin, would it be worth referencing or aligning this implementation with ongoing Miniscript support? This could help ensure compatibility and future-proofing, especially for more complex script use cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add docs for
EsploraAsyncExtand make various doctests runnable.