Skip to content

Make outputs of CLI examples nice#909

Closed
LagginTimes wants to merge 0 commit intobitcoindevkit:masterfrom
LagginTimes:master
Closed

Make outputs of CLI examples nice#909
LagginTimes wants to merge 0 commit intobitcoindevkit:masterfrom
LagginTimes:master

Conversation

@LagginTimes
Copy link
Copy Markdown
Contributor

@LagginTimes LagginTimes commented Mar 19, 2023

Closes #905

Initial work done towards #905 using https://docs.rs/tabled/latest/tabled/.

The following commands are now in table form:

address index
address list
balance
txout list

Copy link
Copy Markdown
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is objectively better than what we had before. Any further improvements can be done later imo.

Copy link
Copy Markdown

@remix7531 remix7531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better. However, this make it a lot harder to grep output.

bdk-table

@notmandatory
Copy link
Copy Markdown
Member

I agree with @remix75 this output format looks good but makes it hard to parse. In many of our existing tutorials with the old bdk-cli we use jq to parse the json output. If we made these tables the default output style can we also add (in a separate PR is OK) a new --json flag (or something like that) to format command outputs as json ?

@LagginTimes LagginTimes force-pushed the master branch 2 times, most recently from e2b658d to 5d1f922 Compare June 21, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Make outputs of CLI examples nice.

4 participants