Skip to content

Add fixes for publishing to crates.io#914

Merged
notmandatory merged 3 commits intobitcoindevkit:masterfrom
notmandatory:add_chain_readme
Mar 28, 2023
Merged

Add fixes for publishing to crates.io#914
notmandatory merged 3 commits intobitcoindevkit:masterfrom
notmandatory:add_chain_readme

Conversation

@notmandatory
Copy link
Copy Markdown
Member

@notmandatory notmandatory commented Mar 20, 2023

Description

To publish the bdk_chain crate I had to either fix the relative reference or create a local README. I decided to add a local README where we can put more detailed docs about bdk_chain. I also had to remove a keyword (max allowed is 5) and add a description to the cargo meta data for bdk_file_store.

Notes to the reviewers

For now the README is just a stub to be filled in later. I already merged this change into the release/1.0.0-alpha branch so I could get the alpha.0 release out today but I'm open to other solutions for the next alpha.1 release.

Changelog notice

None

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added this to the 1.0.0-alpha.1 milestone Mar 20, 2023
@notmandatory notmandatory self-assigned this Mar 20, 2023
@notmandatory notmandatory changed the title Add bdk_chain README Add fixes for deploying to crates.io Mar 20, 2023
@notmandatory notmandatory changed the title Add fixes for deploying to crates.io Add fixes for publishing to crates.io Mar 20, 2023
Copy link
Copy Markdown
Contributor

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5a090fa

I will try to add more info the chain readme later. For now this is good to go..

@notmandatory notmandatory merged commit 5a090fa into bitcoindevkit:master Mar 28, 2023
@notmandatory notmandatory deleted the add_chain_readme branch May 26, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants