Add fixes for publishing to crates.io#914
Merged
notmandatory merged 3 commits intobitcoindevkit:masterfrom Mar 28, 2023
Merged
Conversation
22 tasks
rajarshimaitra
approved these changes
Mar 28, 2023
Contributor
rajarshimaitra
left a comment
There was a problem hiding this comment.
ACK 5a090fa
I will try to add more info the chain readme later. For now this is good to go..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To publish the
bdk_chaincrate I had to either fix the relative reference or create a local README. I decided to add a local README where we can put more detailed docs aboutbdk_chain. I also had to remove a keyword (max allowed is 5) and add a description to the cargo meta data forbdk_file_store.Notes to the reviewers
For now the README is just a stub to be filled in later. I already merged this change into the
release/1.0.0-alphabranch so I could get the alpha.0 release out today but I'm open to other solutions for the next alpha.1 release.Changelog notice
None
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing