Add default std feature, prep for 0.28.0 release#930
Merged
notmandatory merged 3 commits intobitcoindevkit:release/0.27from Apr 5, 2023
Merged
Add default std feature, prep for 0.28.0 release#930notmandatory merged 3 commits intobitcoindevkit:release/0.27from
std feature, prep for 0.28.0 release#930notmandatory merged 3 commits intobitcoindevkit:release/0.27from
Conversation
703f53a to
f507185
Compare
3 tasks
std featurestd feature, prep for 0.28.0 release
rajarshimaitra
approved these changes
Apr 5, 2023
Contributor
rajarshimaitra
left a comment
There was a problem hiding this comment.
ACK cbcbdd1
I tested the builds with a few regular combinations. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new
stdfeature which enablesbitcoin/stdandminiscript/std, and enablestdfeature indefaultfeature set.Notes to the reviewers
When using
bdkin a wasm environment thendefaultfeatures should be disabled andbitcoin/no-stdandminiscript/no-stdmust be enabled. This is a breaking change for anyone usingbdkwith--no-default-features.I also updated the workflows to also run for
release/*branches in addition tomaster.Changelog notice
Changed
stdfeature as part ofdefaultfeatures,stdmust be enabled unless building for wasm.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: