Test esplora ext#931
Closed
vladimirfomene wants to merge 1 commit intobitcoindevkit:masterfrom
Closed
Conversation
vladimirfomene
force-pushed
the
test_esplora_ext
branch
2 times, most recently
from
c5800f6 to
a2e2e13
Compare
vladimirfomene
force-pushed
the
test_esplora_ext
branch
from
a2e2e13 to
2251280
Compare
Write tests for scanning using blocking Esplora client. This test focuses on testing stop gap and reorgs. There is also a focus on scanning with script pubkeys, with outpoints and txids.
vladimirfomene
force-pushed
the
test_esplora_ext
branch
from
6387d00 to
df00edb
Compare
Member
|
Can we keep this in the alpha.1 milestone? does it need anything more than a rebase now that #976 is merged? |
19 tasks
Member
|
Moved this to beta release so we can focus final alpha releases on functional changes, leaving additional test/example/doc changes to beta milestone. |
Collaborator
|
I think this PR is being superseded by @LagginTimes if I understand correctly. @vladimirfomene how to avoid wasting your time by having PRs like this slip is something we need to discuss. Not that it was totally wasted - this PR was a good starting point for future work but I feel like:
|
Contributor
Author
|
Yes this PR was definitely ahead of its time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds test for scanning using both the blocking and async Esplora client. This code is subject to change given the redesign of BDK chain. I will leave this as a draft and will pick it up once #926 .