Fix release/0.28 branch 1.57 MSRV errors#991
Merged
notmandatory merged 4 commits intobitcoindevkit:release/0.28from Jun 16, 2023
Merged
Fix release/0.28 branch 1.57 MSRV errors#991notmandatory merged 4 commits intobitcoindevkit:release/0.28from
notmandatory merged 4 commits intobitcoindevkit:release/0.28from
Conversation
notmandatory
force-pushed
the
fix_157_msrv
branch
3 times, most recently
from
13f7703 to
93d312e
Compare
notmandatory
force-pushed
the
fix_157_msrv
branch
from
93d312e to
32fd39d
Compare
Member
Author
|
This is ready to go now. |
19 tasks
notmandatory
force-pushed
the
fix_157_msrv
branch
2 times, most recently
from
45e519d to
1585ad4
Compare
Member
Author
|
This is ready to go now with other MSRV 1.57 fixes and without pinned |
Member
Author
|
@vladimirfomene this is the PR I mentioned on the call today that needs another review. |
notmandatory
force-pushed
the
fix_157_msrv
branch
from
1585ad4 to
0f25c6a
Compare
vladimirfomene
approved these changes
Jun 7, 2023
Contributor
vladimirfomene
left a comment
vladimirfomene
left a comment
There was a problem hiding this comment.
@notmandatory LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #986 for the release/0.28 branch. I ran into other build issues for 1.57 that I also needed to fix.
Notes to the reviewers
The base64 issue happened a few days ago, I'm not sure when all the others broke but need to be fixed anyway.
EDIT: I also restored the bitcoin/base64 dev-dependency that was waiting for a rust-bitcoin fix released in 0.29.0.EDIT: I bumped base64 to 0.21.2 since the team there removed the MSRV change in that version
EDIT: base64 team made a patch release to restore support for MSRV 1.5.7.0
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingBugfixes: