Skip to content

chore(example_wallet_esplora_async): bump tokio to 1.38.1#219

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
luisschwab:chore/bump-tokio
Apr 30, 2025
Merged

chore(example_wallet_esplora_async): bump tokio to 1.38.1#219
notmandatory merged 1 commit intobitcoindevkit:masterfrom
luisschwab:chore/bump-tokio

Conversation

@luisschwab
Copy link
Copy Markdown
Member

@luisschwab luisschwab commented Apr 24, 2025 •
edited
Loading

Description

This PR bumps tokio to 1.38.1 on example_wallet_esplora_async due to a security vulnerability.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@luisschwab luisschwab mentioned this pull request Apr 24, 2025
Open
6 tasks
@luisschwab
Copy link
Copy Markdown
Member Author

luisschwab commented Apr 24, 2025 •
edited
Loading

Oh, this is conflicting with MSRV. I will leave this PR as a draft until we bump it.

@luisschwab luisschwab marked this pull request as draft April 24, 2025 21:53
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14681874591

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.525%
Totals Coverage Status
Change from base Build 14270666930: 0.0%
Covered Lines: 7269
Relevant Lines: 8401
💛 - Coveralls

@notmandatory notmandatory added the dependencies Pull requests that update a dependency file label Apr 26, 2025
@notmandatory notmandatory moved this to Needs Review in BDK Wallet Apr 26, 2025
@notmandatory notmandatory added this to the Wallet 2.0.0 milestone Apr 26, 2025
@notmandatory
Copy link
Copy Markdown
Member

notmandatory commented Apr 26, 2025 •
edited
Loading

since we're already on tokio version 1 any builds will already pick up the latest, right? If so go ahead and close this.

Nevermind, I see there's an insecurity with older versions.

@notmandatory notmandatory removed this from the Wallet 2.0.0 milestone Apr 26, 2025
notmandatory
notmandatory reviewed Apr 26, 2025
View reviewed changes
Comment thread examples/example_wallet_esplora_async/Cargo.toml Outdated
@luisschwab luisschwab changed the title chore(example_wallet_esplora_async): bump tokio to 1.44.2 chore(example_wallet_esplora_async): bump tokio to 1.38.1 Apr 26, 2025
@luisschwab luisschwab requested a review from notmandatory April 26, 2025 13:59
@luisschwab luisschwab marked this pull request as ready for review April 26, 2025 14:36
notmandatory
notmandatory approved these changes Apr 30, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f4d03b0

@notmandatory notmandatory added this to the Wallet 2.0.0 milestone Apr 30, 2025
@notmandatory notmandatory merged commit 8eaf1c0 into bitcoindevkit:master Apr 30, 2025
14 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in BDK Wallet Apr 30, 2025
@luisschwab luisschwab deleted the chore/bump-tokio branch September 22, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@luisschwab luisschwab

Labels

dependencies Pull requests that update a dependency file

Projects

BDK Wallet
Archived in project

Milestone

Wallet 2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@luisschwab @coveralls @notmandatory